fix: support Java records as JPA @IdClass - #2819
Closed
hantsy wants to merge 1 commit into
Closed
Conversation
fix: support Java records as JPA @IdClass createPrimaryKeyInstance() assumed the primary key class could be built via a no-arg constructor followed by field reflection. Records have neither a no-arg constructor nor writable fields. Detect a record pkClass and build it via RecordInstantiationPolicy and its canonical constructor. @
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@
Support a
java.lang.Recordused as a JPA@IdClass.Root cause
CMPPolicy.createPrimaryKeyInstance()assumed the id class could be built via a no-arg constructor followed byaccessor.setValue(...). Records have neither a no-arg constructor nor writable fields.Fix
Detect a record
pkClassand build the primary key instance viaRecordInstantiationPolicyusing the record canonical constructor.Test
TestRecordIdClassuses aRecordIdClass(UUID id, String code)record as the@IdClassofRecordIdClassEntity, covering persist/find andPersistenceUnitUtil.getIdentifier.Depends on #2817 (record
@Embeddablepolicy plumbing).@